New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Rich text component #1532

Merged

LynxLynxx merged 12 commits into main from feat/1414-rich-text-component

Jan 17, 2025

Contributor

LynxLynxx commented Jan 16, 2025 •

edited

Loading

Description

Users can enter rich text responses so that I can give long-form unstructured details about my proposal.

Related Issue(s)

Resolves #1414

Description of Changes

Changing VoicesRichText implementation to confirm to FormField protocol and to work with MultilineMarkdownDefiniton form schema

Screenshots

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module

LynxLynxx added 3 commits

January 15, 2025 13:08


          feat: creating multiline text entry markdown widget

cf3c90c


          Merge branch 'main' of github.com:input-output-hk/catalyst-voices int…

8dea512

…o feat/1414-rich-text-component


          feat: markdown to quill editor

5dc8c2d

LynxLynxx self-assigned this

LynxLynxx added comment me ux/ui labels

Contributor

github-actions bot commented Jan 16, 2025

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

LynxLynxx and others added 2 commits

January 17, 2025 09:37


          feat: adding validation to VoicesRichText

54d70b1


          Merge branch 'main' into feat/1414-rich-text-component

7d6a278

LynxLynxx marked this pull request as ready for review

January 17, 2025 08:41

LynxLynxx requested review from dtscalac and damian-molinski as code owners

January 17, 2025 08:41


          fix: format

681157c

Contributor

github-actions bot commented Jan 17, 2025

❌ Test Report | ${\color{lightgreen}Pass: 374/378}$ | ${\color{red}Fail: 4/378}$ |

dtscalac reviewed

View reviewed changes

...st_voices/apps/voices/lib/widgets/document_builder/multiline_text_entry_markdown_widget.dart Outdated Show resolved Hide resolved

damian-molinski reviewed

View reviewed changes

...st_voices/apps/voices/lib/widgets/document_builder/multiline_text_entry_markdown_widget.dart Outdated Show resolved Hide resolved

...st_voices/apps/voices/lib/widgets/document_builder/multiline_text_entry_markdown_widget.dart Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Jan 17, 2025

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |


          fix: remove unsessacary markdowncodec objects

b148448

Contributor

github-actions bot commented Jan 17, 2025

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

LynxLynxx added review me and removed comment me labels

dtscalac reviewed

View reviewed changes

...st_voices/apps/voices/lib/widgets/document_builder/multiline_text_entry_markdown_widget.dart Outdated Show resolved Hide resolved

dtscalac reviewed

View reviewed changes

catalyst_voices/apps/voices/lib/widgets/rich_text/voices_rich_text.dart Outdated Show resolved Hide resolved


          fix: controller assigning in initState

dd2d1a4

LynxLynxx requested a review from dtscalac

January 17, 2025 13:12

dtscalac reviewed

View reviewed changes

...st_voices/apps/voices/lib/widgets/document_builder/multiline_text_entry_markdown_widget.dart Show resolved Hide resolved


          fix: deleting final keyword from text controller

0efffb3

Contributor

github-actions bot commented Jan 17, 2025

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |


          fix: adding remove/add listener when didUpdateWidget was called

bd4fd7f

Contributor

github-actions bot commented Jan 17, 2025

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |


          fix: dispose controller

99d03a7

Contributor

github-actions bot commented Jan 17, 2025

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

dtscalac approved these changes

View reviewed changes

Contributor

dtscalac left a comment

LGTM


          Merge branch 'main' into feat/1414-rich-text-component

4b3ba29

LynxLynxx enabled auto-merge (squash)

January 17, 2025 14:05

LynxLynxx merged commit 60da975 into main

35 checks passed

LynxLynxx deleted the feat/1414-rich-text-component branch

January 17, 2025 14:19

Contributor

github-actions bot commented Jan 17, 2025

✅ Test Report | ${\color{lightgreen}Pass: 392/392}$ | ${\color{red}Fail: 0/392}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me ux/ui